Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation on context template removal #15608

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add validation on context template removal #15608

wants to merge 3 commits into from

Conversation

mgodwan
Copy link
Member

@mgodwan mgodwan commented Sep 3, 2024

Description

Prevent removal of system templates used via context in indices.

Related Issues

Prevent removal of system templates used via context in indices.

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

❌ Gradle check result for 6a90a58: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@mgodwan mgodwan self-assigned this Sep 3, 2024
@mgodwan mgodwan added Indexing Indexing, Bulk Indexing and anything related to indexing skip-changelog labels Sep 3, 2024
@mgodwan
Trigger Build
4a8cf94 
Signed-off-by: Mohit Godwani <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

❌ Gradle check result for 4a8cf94: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@mgodwan
Trigger Build
57522c6 
Signed-off-by: Mohit Godwani <[email protected]>
@mgodwan mgodwan marked this pull request as ready for review September 3, 2024 11:08
@mgodwan mgodwan requested a review from VachaShah as a code owner September 3, 2024 11:08
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

✅ Gradle check result for 57522c6: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Sep 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.91%. Comparing base (a5590d1) to head (57522c6).
Report is 354 commits behind head on main.

Files with missing lines Patch % Lines
...cluster/metadata/MetadataIndexTemplateService.java 83.33% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #15608      +/-   ##
============================================
+ Coverage     71.85%   71.91%   +0.06%     
- Complexity    63847    63904      +57     
============================================
  Files          5257     5257              
  Lines        298543   298555      +12     
  Branches      43164    43165       +1     
============================================
+ Hits         214507   214720     +213     
+ Misses        66421    66222     -199     
+ Partials      17615    17613       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Sep 9, 2024
Open
@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added stalled Issues that have stalled and removed stalled Issues that have stalled labels Oct 3, 2024
@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added stalled Issues that have stalled and removed stalled Issues that have stalled labels Nov 5, 2024
@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added the stalled Issues that have stalled label Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@mgodwan mgodwan

Labels
Indexing Indexing, Bulk Indexing and anything related to indexing skip-changelog stalled Issues that have stalled
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mgodwan